Skip to content

[csharp][generichost] Refactor duplicate apis#24273

Merged
wing328 merged 2 commits into
OpenAPITools:masterfrom
devhl-labs:devhl/refactor-duplicate-apis
Jul 12, 2026
Merged

[csharp][generichost] Refactor duplicate apis#24273
wing328 merged 2 commits into
OpenAPITools:masterfrom
devhl-labs:devhl/refactor-duplicate-apis

Conversation

@devhl-labs

@devhl-labs devhl-labs commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Minor refactor only because this edge case is interfering in another change I want to make. I'm not sure why the api spec having tags results in duplicate apis, I'd like to see that removed. But until then we can just do this refactor.

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Refactored the C# GenericHost templates to always generate unique ApiResponse types when tags create duplicate APIs. Response interfaces/classes are now prefixed with the API classname and used consistently across method signatures, events, logging, and constructors.

  • Refactors

    • In api.mustache, use vendorExtensions.x-duplicates with template lambdas to prefix ApiResponse interface/class names with the API classname, and propagate to return types (including OrDefault), event ExecuteOn* signatures, logger generics, and response construction.
    • Regenerated samples use unique names, e.g. IAPIKeysApiGetApiKeysIdApiResponse/APIKeysApiGetApiKeysIdApiResponse and IApiKeysApiGetApiKeysIdApiResponse/ApiKeysApiGetApiKeysIdApiResponse.
  • Migration

    • If you reference generated response types directly, update to the new prefixed names (e.g., IGetApiKeysIdApiResponseIAPIKeysApiGetApiKeysIdApiResponse).

Written for commit df29ada. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@wing328 wing328 added Client: C-Sharp Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Jul 12, 2026
@wing328 wing328 added this to the 7.24.0 milestone Jul 12, 2026
@wing328 wing328 merged commit cdf4623 into OpenAPITools:master Jul 12, 2026
35 checks passed
@devhl-labs devhl-labs deleted the devhl/refactor-duplicate-apis branch July 12, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client: C-Sharp Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants